-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to winit 0.29 #3649
Update to winit 0.29 #3649
Conversation
Current status: At least on mac, running |
I prepared patch that updates I think it matches in this PR as:
In example Digression 1This patch is minimal adaptation to new (currently I have some ideas on updating loaders (it will fix issue with svg and enable reloading image if file has been changed):
As these will require changes that are completely unrelated to Digression 2: |
@PingPongun thanks for the patch, but let's wait with the resvg update for a separate PR - this one is big enough as is 😓 |
I was testing to see if this branch fixes #3673, which it does, but on my machine it makes the main viewport on the demo app stop repainting whenever it is in the foreground and the extra viewport is open. The person who opened the issue did not observe the same behavior on their machine, which has a similar but different setup. winit_029_demo_app.mp4Here is my setup:
|
Another problem I found: the modifier keys are ignored. Both the left and the right ones. They don't appear as down in the inspection window in the demo app, and they don't have any other effect either (aside from making text upper case, in the case of the shift key). |
According to @Wumpf this seems to work pretty well on Windows now. |
IME seems to work on my Mac. Are there any more blockers to merging this? |
Just tried it out on Linux Mint 21.2, everything seems to be working perfectly aside from window dragging, which causes the window to fly into the top left corner of the screen (see video) I've tested to make sure every letter on my keyboard works + modifiers, as well as the various demos in the demo app. Nothing obvious that's different aside form the previously mentioned bug. out.mp4 |
Thanks @Vickerinox - I think that is an acceptable level of regression. If anyone wants that feature to work they can make a PR :) |
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> This breaking change seems to have snuck in during #3649. Previously it would never consume these, today it consumes them unconditionally, and with this change it'll ~~only consume them if egui wants text input~~ never consume them. This is a blocker for updating our application, sadly :(
this partly restores event-emitting behaviour to the state before emilk#3649, when shortcuts such as Ctrl-C used to work regardless of the active layout. the difference is that physical keys are only used in case of the logical ones' absence now among the named keys.
…ve (#4461) resolves #4081 (see discussion starting from #3653 (comment) for extra context) this partly restores event-emitting behaviour to the state before #3649, when shortcuts such as `Ctrl` + `C` used to work regardless of the active layout. the difference is that physical keys are only used in case of the logical ones' absence now among the named keys. while originally I have only limited this to clipboard shortcuts (Ctrl+C/V/X), honestly it felt like a half-assed solution. as a result, I decided to expand this behaviour to all key events to stick to the original logic, in case there are other workflows and hotkeys people rely on or expect to work out of the box. let me know if this is an issue.
…ve (emilk#4461) resolves emilk#4081 (see discussion starting from emilk#3653 (comment) for extra context) this partly restores event-emitting behaviour to the state before emilk#3649, when shortcuts such as `Ctrl` + `C` used to work regardless of the active layout. the difference is that physical keys are only used in case of the logical ones' absence now among the named keys. while originally I have only limited this to clipboard shortcuts (Ctrl+C/V/X), honestly it felt like a half-assed solution. as a result, I decided to expand this behaviour to all key events to stick to the original logic, in case there are other workflows and hotkeys people rely on or expect to work out of the box. let me know if this is an issue.
scancodes
via egui-winit #2977